[11.x] Add Relation::getMorphAlias()
#51809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxlrbt
changed the title
Relation::getMorphAlias()
calebdw
reviewed
Jun 17, 2024
Co-authored-by: Caleb White <[email protected]>
Tofandel
reviewed
Jun 19, 2024
| */ | ||
| public static function getMorphAlias(string $className) | ||
| { | ||
| return array_flip(static::$morphMap)[$className] ?? null; |
There was a problem hiding this comment.
Shouldn't this have been array_search($className, static::$morphMap) ?: $className
array_search performs about 3 times better in this kind of configuration than array_flip
Why return null and not the original class name?
This makes the example in the description much more verbose now and not a drop in replacement for $model->getMorphClass()
$this->assertDatabaseHas('taskables', [
'taskable_type' => Relation::getMorphAlias(Document::class) ?? Document::class,
'taskable_id' => $mitigation->id,
'task_id' => $taskB->id
]);
There was a problem hiding this comment.
Thanks @calebdw for improving this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is a
Relation::getMorphedModel()I think it would be beneficial to add the reversegetMorphAlias.This addition is particularly beneficial for testing, as it simplifies assertions with $this->assertDatabaseHas. Developers no longer need to recall the morph alias used:
A similar PR with a broader scope was previously submitted:
#43487